Help with a script with two conditions

[Fernando DS]

Hi. I want to do an script for autocomplete a note field called “Comentario” with “Buen disco.”, when the valoration field “Valoración” has four stars and, at once, the field “Comentario” is empty. I have not errors in the console, but the script does not work. Any help will be welcome. Thank you.

 

Attachments:

You must be logged in to view attached files.

[Brendan]

Hi Fernando,

try == instead of ===. But it could also be that you just need to check for 4 instead of "4" because the Rating field returns a number, not a string and you’re checking to see if the value is the string "4" and not the number 4.

[Fernando DS]

Hi Brendan, thank you for your answer. The script is steel not working.

Attachments:

You must be logged in to view attached files.

[Daniel Leu]

There’s a second “===” instead of a “==”.

[Fernando DS]

It’s true. I have corrected it, but the result is the same.

Attachments:

You must be logged in to view attached files.

[Daniel Leu]

It would be easier if you posted your code here instead of the screen capture. But I think that the form.saveAllChanges() should be before the closing bracket above.

[Fernando DS]

Sorry for my ignorance, but how do I send the code?

[Fernando DS]

Well, I’m going to paste it here.

 

function modifyFieldsBasedOnCondition() {
var fieldId1 = 'fld-28b97ce8ab4f4f57a83aefa7e91f17fe';
var fieldId2 = 'fld-c2fd26ae62c1445692b3a0abc1e89158';

for (var record of form.getRecords()) {
if (record.getFieldValue(fieldId1) == 4 &&
record.getFieldValue(fieldId2) == "") {
record.setFieldValue(fieldId2, "Buen disco.");
}
}

form.saveAllChanges();
}

modifyFieldsBasedOnCondition();

• This reply was modified 5 months, 1 week ago by Brendan.

[Fernando DS]

Hope this is what you said Daniel.

[Brendan]

Hi Fernando,

What type of field is fieldId2? Is it a Text field or a Number field? Because you’re comparing it to the empty string "".

You might want to check to see if it’s undefined

[Fernando DS]

It’s a note field. I write my opinions about discs in it and I need enough extension.

[Fernando DS]

So it’s a field of text, not numbers.

[Fernando DS]

Just another try, without errors in console, but not works.

function modifyFieldsBasedOnCondition() {
var fieldId1 = 'fld-28b97ce8ab4f4f57a83aefa7e91f17fe';
var fieldId2 = 'fld-c2fd26ae62c1445692b3a0abc1e89158';

for (var record of form.getRecords()) {
if (record.getFieldValue(fieldId1) == 4 &&
record.getFieldValue(fieldId2) <= (0))
record.setFieldValue(fieldId2, "Buen disco.");
}
}

form.saveAllChanges();

modifyFieldsBasedOnCondition();

• This reply was modified 5 months, 1 week ago by Brendan.

[Daniel Leu]

This works for me:

 function modifyFieldsBasedOnCondition() {
var fieldId1 = 'fld-28b97ce8ab4f4f57a83aefa7e91f17fe';
var fieldId2 = 'fld-c2fd26ae62c1445692b3a0abc1e89158';

   for (var record of form.getRecords()) {
      console.log(record.getFieldValue(fieldId1));
      console.log(record.getFieldValue(fieldId2));

      if (record.getFieldValue(fieldId1) == 4 &&
         record.getFieldValue(fieldId2) == undefined)
      {
         record.setFieldValue(fieldId2, "Buen disco.");
         console.log("empty record found");
      }
   }
   form.saveAllChanges();
}

modifyFieldsBasedOnCondition();

• This reply was modified 5 months, 1 week ago by Daniel Leu.
• This reply was modified 5 months, 1 week ago by Daniel Leu.
• This reply was modified 5 months, 1 week ago by Daniel Leu.
• This reply was modified 5 months, 1 week ago by Daniel Leu.
• This reply was modified 5 months, 1 week ago by Daniel Leu.

[Fernando DS]

At last this is the script that works:

function modifyFieldsBasedOnCondition() {
var fieldId1 = ‘fld-28b97ce8ab4f4f57a83aefa7e91f17fe’;
var fieldId2 = ‘fld-c2fd26ae62c1445692b3a0abc1e89158’;

for (var record of form.getRecords()) {
var valueField1 = record.getFieldValue(fieldId1);
var valueField2 = record.getFieldValue(fieldId2);

if (valueField1 === 4 && (valueField2 === null || valueField2 === “”)) {
record.setFieldValue(fieldId2, “Buen disco.”);
console.log(“Campo fieldid2 actualizado en el registro con campo fieldid1 igual a 4 y fieldid2 vacío.”);
}
}

form.saveAllChanges();
}

modifyFieldsBasedOnCondition();

 

Thank you Brendan and Daniel for your valuable help.

Bye.

 

[Author]

Posts